🛡️ Sentinel: [MEDIUM] Fix weak random number generation

.jules/sentinel.md

@@ -0,0 +1,4 @@
+## 2024-05-18 - Weak Random Generation in IDs
+**Vulnerability:** The codebase was using the standard `random` module for generating session tokens and identifiers (`helpers/guids.py`).
+**Learning:** The `random` module is not cryptographically secure and predictable, which could compromise generated IDs.
+**Prevention:** Always use the `secrets` module (e.g., `secrets.choice`) for generating random strings where security or unpredictability is needed.

helpers/guids.py

@@ -1,4 +1,4 @@
-import random, string
+import secrets, string
 
 def generate_id(length: int = 8) -> str:
-    return "".join(random.choices(string.ascii_letters + string.digits, k=length))
+    return "".join(secrets.choice(string.ascii_letters + string.digits) for _ in range(length))