🛡️ Sentinel: [MEDIUM] Add resource limits to prevent DoS#37
Conversation
Added strict `timeout` (30s) and `maxBuffer` (5MB) boundaries to shell command executions (`execAsync`) in `ShellTool`. Enforced a `timeout` (30s) on external network requests within the `AgentConnector`'s Axios instance. These changes prevent potential Denial of Service (DoS) attacks caused by resource exhaustion from infinite process hangs or excessive data buffers. Appended critical learning to `.jules/sentinel.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: MEDIUM
💡 Vulnerability: Shell execution tools and external API connectors lacked explicit resource constraints (timeouts, max buffer limits). This could allow malicious or runaway processes to consume excessive CPU, memory, or network connections, leading to a Denial of Service (DoS) of the agent's environment.
🎯 Impact: If exploited, unbounded shell executions or hanging LLM API calls could freeze the agent completely, exhaust server memory, or hold TCP connections open indefinitely, preventing it from functioning.
🔧 Fix: Added
timeout(30000ms) andmaxBuffer(5MB) boundaries toexecAsyncinShellTool. Enforced atimeout(30000ms) on external HTTP/HTTPS network requests within theAgentConnector's Axios instance.✅ Verification: Verified that changes compile correctly (
npm run build) and the test suite passes (npm run test). Documented the learning in.jules/sentinel.md.PR created automatically by Jules for task 1036044308376561475 started by @thirdbase1