Conversation
SamGave07
approved these changes
Mar 9, 2025
Collaborator
SamGave07
left a comment
SamGave07
left a comment
There was a problem hiding this comment.
good enhancement of the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
Circuitclass to improve the organization and display of input components. The most important changes include adding new headers, sorting input components before displaying them, and updating the display logic.Improvements to header organization:
include/Circuit.hpp: Added#include <map>to support the use ofstd::mapfor sorting inputs.src/Circuit.cpp: Added#include <algorithm>to support potential future use of algorithms.Enhancements to input display:
src/Circuit.cpp: Modified thedisplayInputsmethod to sort input components using astd::mapand display them in order. This change ensures that inputs are displayed in a consistent and organized manner.