Conversation
- Until Firedrake issue #3368 is resolved
stephankramer
left a comment
There was a problem hiding this comment.
Thanks @cpjordan
So it might be I'm just misunderstanding - but I would have expected that for interpolated value size we should in fact be using value_size and not block_size. The latter being the n/o DOFs per node, which was what previously returned by value_size in which case it would in fact have been incorrect in Thetis previously. The difference would only appear for RT and BDM velocity fields which we don't use very frequently. I do agree/understand the changes to the OP2 kernel headers in utility.py and utility3d.py - these should indeed be block_size now.
|
Related to firedrakeproject/firedrake#3862 and firedrakeproject/firedrake#3368 |
- Interested in scalar/vector/tensor not DOF structure - Also simplify to fs.value_shape - no need for ufl_element().value_shape
|
@stephankramer - thanks for reviewing and explanation. I had discussed the problems with @connorjward who found that Updated based on the comments above. |
stephankramer
left a comment
There was a problem hiding this comment.
Perfect, many thanks!
Fix various issues with testing: