chore: replace placeholder failing test scripts (#555)#568
Open
Shinyaigeek wants to merge 2 commits into
Open
Conversation
- root `test` → `pnpm -r run test` so `pnpm test` runs the real test suites in lang-core / react-headless / svelte-lang / vue-lang (and skips packages without a `test` script). - drop the `echo "Error: no test specified" && exit 1` placeholder from `packages/react-ui`. - add `--passWithNoTests` to `packages/react-lang`'s `test` so the empty-suite case exits 0 instead of failing the recursive run. The renderer test suite (thesysdev#549) can land on top without further changes. Closes thesysdev#555.
Use the same `vitest run --passWithNoTests` placeholder in @openuidev/react-ui as in @openuidev/react-lang, so: - `pnpm --filter @openuidev/react-ui test` exits 0 instead of "No script named 'test'" (review feedback) - the package is drop-in ready when a real test suite lands (Storybook smoke tests, helper unit tests, etc.) Requires adding `vitest` to react-ui's devDependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #555.
testscript →pnpm -r run test, sopnpm testexits 0 and runs the real suites inlang-core/react-headless/svelte-lang/vue-lang.echo "Error: no test specified" && exit 1placeholder frompackages/react-uiso contributors don't get pointed at a script that fails by design.--passWithNoTeststopackages/react-lang'stest. The renderer package already hadvitestwired up but no*.test.tsfiles, so the recursive run would still exit 1 on it. This flag is a no-op once Add tests for the React OpenUI Lang renderer #549 lands real renderer tests.Verification