Skip to content

fix: Ensure fallback works for LDCs#900

Merged
DafyddLlyr merged 1 commit intomainfrom
dp/ldc-fallback-description
Jan 15, 2026
Merged

fix: Ensure fallback works for LDCs#900
DafyddLlyr merged 1 commit intomainfrom
dp/ldc-fallback-description

Conversation

@DafyddLlyr
Copy link
Copy Markdown
Contributor

@DafyddLlyr DafyddLlyr commented Dec 19, 2025

Before

  • An LDC is received (e.g. lds.listedBuildingWorks)
  • It does not have a value found in ldcDescriptionFns
  • The .join("; ") operations converts the empty array to the falsy ""
  • The fallback condition "Not provided" is reached - despite there being a valid proposal.description

After

  • An LDC is received (e.g. lds.listedBuildingWorks)
  • It does not have a value found in ldcDescriptionFns
  • Fallback to proposal.description if possible, otherwise just "Not provided"

There might well be a content solution alongside this, for example have a LDC LBW specific description field, but having this fallback in place should prevent future issues here.

@DafyddLlyr DafyddLlyr requested a review from a team January 13, 2026 09:12
Copy link
Copy Markdown
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for straightening this one out !

@DafyddLlyr DafyddLlyr merged commit 9ebbbbd into main Jan 15, 2026
4 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/ldc-fallback-description branch January 15, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants