fix: correct compute_contraction_upper_bond typo#244
Open
Ao-chuba wants to merge 1 commit intotheochem:masterfrom
Open
fix: correct compute_contraction_upper_bond typo#244Ao-chuba wants to merge 1 commit intotheochem:masterfrom
Ao-chuba wants to merge 1 commit intotheochem:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@FarnazH
This PR fixes a typo in the function name
compute_contraction_upper_bondlocated in gbasis/screening.py . It has been correctly renamed tocompute_contraction_upper_bound.All corresponding imports and usages, specifically in
tests/test_screening.py, have also been updated to reflect the new spelling.closes #243