Respect StreamElement.render async function#1040
Open
artinboghosian wants to merge 1 commit intothemesberg:mainfrom
Open
Respect StreamElement.render async function#1040artinboghosian wants to merge 1 commit intothemesberg:mainfrom
artinboghosian wants to merge 1 commit intothemesberg:mainfrom
Conversation
The StreamElement.render property is set to an async function in Turbo (see https://github.com/hotwired/turbo/blob/main/src/elements/stream_element.js#L29). As a result we should respect the async nature of the function and only dispatch the after render event once we know rendering has completed, by awaiting render to finish.
Contributor
Author
|
Bumping |
Contributor
Author
|
Bumping @zoltanszogyenyi |
Contributor
Author
|
Bumping |
2 similar comments
Contributor
Author
|
Bumping |
Contributor
Author
|
Bumping |
Contributor
Author
|
@zoltanszogyenyi bumping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StreamElement.render property is set to an async function in Turbo (see https://github.com/hotwired/turbo/blob/main/src/elements/stream_element.js#L29 and https://github.com/hotwired/turbo/blob/main/src/elements/stream_element.js#L167). As a result we should respect the async nature of the function and only dispatch the after render event once we know rendering has completed, by awaiting render to finish.