fix: add missing widget Python files to meson.build install list#3
Draft
fix: add missing widget Python files to meson.build install list#3
Conversation
Fixes Windows CI failure: ModuleNotFoundError for wciviewer_jupyter and other new widget modules that were not included in the meson install sources. Agent-Logs-Url: https://github.com/themachinethatgoesping/pingprocessing/sessions/9f8b2d08-c414-42aa-897e-e01ca39fa6c9 Co-authored-by: peter-urban <3885740+peter-urban@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
peter-urban
April 7, 2026 07:59
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows CI failure (run #23066915267) caused by:
Root Cause
12 new Python files in the
widgetsdirectory were not added to thesourceslist inpython/meson.build, so meson did not install them. Sincewidgets/__init__.pyimports these modules unconditionally, the missing files causedModuleNotFoundErrorat runtime.Changes
Added the following missing files to
python/meson.build:control_jupyter.pycontrol_qt.pycontrol_spec.pyechogramviewer_core.pyechogramviewer_jupyter.pyechogramviewer_qt.pymapviewer_core.pymapviewer_jupyter.pymapviewer_qt.pywciviewer_core.pywciviewer_jupyter.pywciviewer_qt.py