Fix diff-mode returning empty changed files#15
Merged
thejefflarson merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
git diff --name-only --diff-filter=ACMR -- <sha> treats <sha> as a path (not a ref) because of the --. The match returns empty, so diff-mode always short-circuited with 'No changed files. Nothing to review.' Every PR-triggered and push-triggered run under the action was a silent no-op. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git diff --name-only --diff-filter=ACMR -- <sha>treats<sha>as a path, not a ref — always returns empty--so the SHA is parsed as a commit refTest plan
git diff --name-only --diff-filter=ACMR HEAD~1returns the changed files (verified locally)git diff --name-only --diff-filter=ACMR -- HEAD~1returns empty (verified locally)🤖 Generated with Claude Code