Introduce Undefined::VALUE#764
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
============================================
- Coverage 95.72% 94.83% -0.90%
- Complexity 1773 1891 +118
============================================
Files 154 176 +22
Lines 4586 4974 +388
============================================
+ Hits 4390 4717 +327
- Misses 196 257 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for putting this together @oprypkhantc! I'm thinking we should deprecate support for |
|
@oprypkhantc can we get this merged? |
…undefined # Conflicts: # src/Mappers/Parameters/TypeHandler.php
|
Hey @oojacoboo. Sorry, I forgot to update you - I no longer work directly for the company I used to and no longer work with PHP; I might occasionally come back and fix things here and there though :) I updated the PR with deprecation of |
|
@oprypkhantc @autaut03 Thanks for the update, both on the PR and your personal situation. It's been a pleasure working with you on graphqlite. All the best in your new endeavors! |
Closes #726
Tests are incomplete, but otherwise this is ready for review
From my perspective, the next step would be deprecating
isUpdatecompletely - what do you think of that? I didn't include it in this PR as there may be value in trying out theUndefinedapproach first for a larger chunk of users. For us though, this approach has been good.