Skip to content

Introduce Undefined::VALUE#764

Merged
oojacoboo merged 5 commits intothecodingmachine:masterfrom
oprypkhantc:undefined
Apr 24, 2026
Merged

Introduce Undefined::VALUE#764
oojacoboo merged 5 commits intothecodingmachine:masterfrom
oprypkhantc:undefined

Conversation

@oprypkhantc
Copy link
Copy Markdown
Contributor

@oprypkhantc oprypkhantc commented Oct 27, 2025

Closes #726

Tests are incomplete, but otherwise this is ready for review

From my perspective, the next step would be deprecating isUpdate completely - what do you think of that? I didn't include it in this PR as there may be value in trying out the Undefined approach first for a larger chunk of users. For us though, this approach has been good.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.83%. Comparing base (53f9d49) to head (9b98d32).
⚠️ Report is 152 commits behind head on master.

Files with missing lines Patch % Lines
src/Mappers/Parameters/TypeHandler.php 88.88% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #764      +/-   ##
============================================
- Coverage     95.72%   94.83%   -0.90%     
- Complexity     1773     1891     +118     
============================================
  Files           154      176      +22     
  Lines          4586     4974     +388     
============================================
+ Hits           4390     4717     +327     
- Misses          196      257      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oojacoboo
Copy link
Copy Markdown
Collaborator

Thanks for putting this together @oprypkhantc!

I'm thinking we should deprecate support for InputType::isUpdate as part of this PR and update the docs to direct the Undefined "type" as the de facto way of handling update functionality, where nullable support is needed.

@oojacoboo
Copy link
Copy Markdown
Collaborator

@oprypkhantc can we get this merged?

@oprypkhantc
Copy link
Copy Markdown
Contributor Author

Hey @oojacoboo. Sorry, I forgot to update you - I no longer work directly for the company I used to and no longer work with PHP; I might occasionally come back and fix things here and there though :)

I updated the PR with deprecation of update: flag and updated the docs, but feel free to take over if I missed anything; also if you need me for anything you can tag my personal account at @autaut03, I'll see a notification for that one ❤️

@oojacoboo
Copy link
Copy Markdown
Collaborator

@oprypkhantc @autaut03 Thanks for the update, both on the PR and your personal situation. It's been a pleasure working with you on graphqlite. All the best in your new endeavors!

@oojacoboo oojacoboo merged commit 4a700d8 into thecodingmachine:master Apr 24, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type-safe solution for "undefined" input values

3 participants