align field number and naming with py-libp2p reference implementation#1
Merged
theUtkarshRaj merged 1 commit intoMay 8, 2026
Conversation
- Change largeMessageSegmentation field from 8473921 to 6492435 in both ControlExtensions and RPC to match py-libp2p (PR libp2p/py-libp2p#1323) - Rename RPC.largeSegmentation to RPC.largeMessageSegmentation for consistency - Note py-libp2p's 256 KiB default segment size under Open Question 2
shivv23
added a commit
to shivv23/py-libp2p
that referenced
this pull request
May 8, 2026
…field alignment - Switch messageID from raw seqno to SHA-256(publisherID || topic || nonce)[:16] per spec draft recommendation (avoids cross-publisher/cross-topic collisions) - Add compute_message_id() helper to segmentation.py - Add reassembly_timeout config parameter (default 120s) - Align extensions.proto field number 8473921 -> 6492435 (coordination PR: theUtkarshRaj/specs#1)
4 tasks
theUtkarshRaj
merged commit afb88e1
into
theUtkarshRaj:experimental/large-message-segmentation
Owner
|
Thanks @shivv23 — these align cleanly with what we discussed. The rename to largeMessageSegmentation is a good catch, and locking in 6492435 plus the 256 KiB implementation note in Open Question 2 keeps spec and reference implementation in lockstep. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the spec draft with the py-libp2p reference implementation (libp2p/py-libp2p#1323).
Changes
Field number:
largeMessageSegmentationchanged from8473921→6492435in bothControlExtensionsandRPC. Both values are in the experimental range (>0x200000), so this is purely a coordination change. The py-libp2p implementation already uses6492435.RPC field naming: Renamed
RPC.largeSegmentation→RPC.largeMessageSegmentationfor consistency withControlExtensions.largeMessageSegmentationand the py-libp2p field name.Segment size note: Added a note that the py-libp2p reference implementation defaults to 256 KiB per segment payload (under the spec's 1 MiB ceiling), under Open Question 2.
Related