refactor: downloads history as spatial sidebar destination

[yonaries]

Summary

• Downloads history view — a dedicated sidebar destination that slides in with a spatial push-back transition on the spaces content, replacing the old popover
• Search & date grouping — filter downloads by name/URL, grouped by date (Today, Yesterday, This Week, etc.)
• Native file icons — uses NSWorkspace icons matching Finder instead of SF Symbols
• Circular progress indicator — replaces the inline download progress list with a ring around the sidebar icon
• Unified action menu — single ellipsis button per row with Open, Show in Finder, Copy Path, Move to Trash, Retry, Remove from Ora
• Smart tab management — auto-closes tabs opened solely for file downloads; navigates back when an existing page triggers a download
• Interactive gestures — swipe right to dismiss downloads, swipe left from first space to enter
• Custom Ora icons — DownloadBox and Brush icons for sidebar widget and clear button

[greptile-apps]

Greptile Summary

Replaces the downloads popover with a full spatial sidebar destination that slides in with push-back transitions. The new view adds search, date-grouped history, native file icons, a circular progress indicator on the sidebar widget, a unified per-row action menu, and smart tab management that auto-closes download-only tabs.

• Spatial navigation: SidebarView now wraps spaces content and DownloadsHistoryView in a ZStack with interactive swipe gestures and spring-animated transitions
• Downloads history: New DownloadsHistoryView with search filtering, date bucketing (Today → Older), and a "Clear" button; new DownloadHistoryRow with native NSWorkspace file icons, context menus, and inline progress
• DownloadsWidget refactor: Replaced inline download list + popover with a compact icon button featuring a circular progress ring around the download icon
• Smart tab management: TabBrowserPageDelegate now navigates back or closes tabs that were opened solely for file downloads, using the newly exposed lastCommittedURL and isDownloadNavigation from BrowserPage
• New manager methods: openFile, moveToTrash, and retryDownload added to DownloadManager; recent downloads limit bumped from 20 to 50
• Bug: The "Clear" button visibility (hasNonActiveDownloads) includes failed/cancelled downloads, but clearCompletedDownloads() only removes .completed entries — failed/cancelled downloads won't be cleared

Confidence Score: 4/5

• This PR is safe to merge with one minor logic mismatch in the Clear button behavior that should be addressed.
• Well-structured refactor with clean separation of concerns. The spatial transition, gesture handling, and smart tab management are all correctly implemented. The only functional issue is the Clear button visibility/action mismatch in DownloadsHistoryView. The icon files are pure geometry with no concerns.
• ora/Features/Downloads/Views/DownloadsHistoryView.swift and ora/Features/Downloads/Services/DownloadManager.swift — the Clear button appears for failed/cancelled downloads but clearCompletedDownloads() only removes completed ones.

Important Files Changed

Filename	Overview
ora/Core/BrowserEngine/BrowserPage.swift	Widens access to lastCommittedURL and isDownloadNavigation via private(set) to enable smart tab management in the delegate. Minimal, clean change.
ora/Features/Downloads/Services/DownloadManager.swift	Adds openFile, moveToTrash, and retryDownload methods; bumps recent downloads limit to 50; adds objectWillChange dispatch for WKDownload callback timing. clearCompletedDownloads only clears .completed status, which mismatches the UI visibility check.
ora/Features/Downloads/Views/DownloadHistoryRow.swift	New file implementing per-download row with native file icons, progress bar, hover menu, and context menu. Well-structured with good separation of concerns.
ora/Features/Downloads/Views/DownloadsHistoryView.swift	New downloads history sidebar view with search, date grouping, and clear functionality. Has a logic mismatch between the Clear button visibility and the clear action scope.
ora/Features/Sidebar/Views/DownloadsWidget.swift	Major refactor from inline download list + popover to a compact icon button with circular progress ring. Clean replacement of the old approach.
ora/Features/Sidebar/Views/SidebarView.swift	Adds spatial transition between spaces and downloads history with interactive swipe gestures. Well-implemented with proper drag threshold and spring animations.
ora/Features/Tabs/Browser/TabBrowserPageDelegate.swift	Smart tab management: navigates back on download if page has history, otherwise closes download-only tabs. Timing is correct since delegate runs synchronously before isDownloadNavigation reset.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DownloadsWidget Button Tap] -->|toggle| B[isShowingDownloadsHistory]
    B -->|true| C[SidebarView Spatial Transition]
    C --> D[DownloadsHistoryView slides in]
    D --> E[spacesContent pushes back + fades]

    F[Swipe Left from Space 0] -->|threshold met| B
    G[Swipe Right on Downloads] -->|threshold met| H[isShowingDownloadsHistory = false]
    H --> I[DownloadsHistoryView slides out]
    I --> J[spacesContent restores]

    K[WKDownload Triggered] --> L[BrowserPage.isDownloadNavigation = true]
    L --> M[TabBrowserPageDelegate.didStartDownload]
    M --> N{lastCommittedURL?}
    N -->|exists| O[tab.goBack]
    N -->|nil| P[tabManager.closeTab]

Loading

_{Last reviewed commit: b332790}