Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major new release (v3.0.0) of Express Storage, focusing on breaking changes, improved type safety, modularity, and developer experience. The most important updates include making cloud SDKs optional peer dependencies, refactoring result types to discriminated unions, removing presigned driver subclasses, and updating the documentation and workflows to match the new requirements.
Breaking API and Dependency Changes
FileUploadResult,DeleteResult, etc.) are now discriminated unions with asuccess: true | falseflag, improving TypeScript narrowing and error handling.S3PresignedStorageDriver, etc.) have been removed; base driver classes now handle both direct and presigned modes internally..fileName→.referenceacross result types, andrateLimit→rateLimiterin options.Documentation and Developer Experience
README.mdhas been extensively rewritten to clarify features, quick start, error codes, API reference, and migration instructions. It now explicitly instructs users to install only the required cloud SDKs. [1] [2] [3] [4]CI/CD and Node Version Updates
publish.yml,push.yml) have been updated to use Node.js 22.x for all jobs, aligning with the new minimum engine requirement. [1] [2] [3]Changelog and Release Management
CHANGELOG.mdhas been completely rewritten to document all breaking changes, new features, removals, and migration guidance for v3.0.0.References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]