Update annotSeg_7102f1c.pl#471
Open
tizatt wants to merge 19 commits intotgen:developfrom
Open
Conversation
Lancet changes to sync with other pipelines
Quick bugfix
Update pipeline.yaml
Release v1.1.0
Increment pipeline version
Mutation burden bugfix
Release v1.1.1
Pipeline version bump for v1.1.1
Release v1.1.2
v1.1.2 versioning
release_v1.2
Release v1.2 versioning
AnnotSeg creates a window from which genes are selected from the ensembl gtf. This window was found to be too large and is annotating beyond the actual region of genes. Because it was doing a division/multiplication before a subtraction - this caused windows to be thousands of bp larger than what they actually should be. This fix takes care of making the window size more accurate by doing the subtraction/addition before multiplication/division.
Member
|
@tizatt can you update teh pull request to be to develop, this update will require a release update. @bryce-turner is this code running in tempe? |
Author
|
Ok yes I can do it for the develop |
Member
Currently not in tempe, avoiding a perl container for an output not many people use. Plus the implementation is theoretical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnnotSeg creates a window from which genes are selected from the ensembl gtf. This window was found to be too large and is annotating beyond the actual region of genes. Because it was doing a division/multiplication before a subtraction - this caused windows to be thousands of bp larger than what they actually should be. This fix takes care of making the window size more accurate by doing the subtraction/addition before multiplication/division.