refactor(data-space): reuse Bytes for Prove and Verify mode#759
Merged
vapourismo merged 1 commit intomainfrom Feb 5, 2026
Merged
refactor(data-space): reuse Bytes for Prove and Verify mode#759vapourismo merged 1 commit intomainfrom
vapourismo merged 1 commit intomainfrom
Conversation
c97c2be to
6b75b4b
Compare
72c6c59 to
20836b3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 90.80% 90.98% +0.17%
==========================================
Files 111 111
Lines 20963 20878 -85
Branches 20963 20878 -85
==========================================
- Hits 19036 18995 -41
+ Misses 1534 1491 -43
+ Partials 393 392 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6b75b4b to
7a8756b
Compare
20836b3 to
0d8e813
Compare
7a8756b to
008c5b6
Compare
0d8e813 to
b5bfe32
Compare
008c5b6 to
b7c3e30
Compare
b5bfe32 to
3549ee5
Compare
d999839 to
cb30540
Compare
145e361 to
533c402
Compare
cb30540 to
bccee93
Compare
533c402 to
270957f
Compare
bccee93 to
c31d3f0
Compare
270957f to
1816d14
Compare
c31d3f0 to
ba361fa
Compare
9a3b501 to
35fcd7e
Compare
ba361fa to
55713d3
Compare
55713d3 to
f2ed91e
Compare
2b1e310 to
6b3fb0a
Compare
9 tasks
6b3fb0a to
0f4c965
Compare
b618c42 to
347edf5
Compare
f1b00db to
29194dc
Compare
|
Benchmark results for revision d0a0c8a:
Full results
Compare the results above with those for the default branch. |
29194dc to
a2c1ad1
Compare
0c21799 to
98b23c1
Compare
a2c1ad1 to
eab87fb
Compare
98b23c1 to
4be6f32
Compare
eab87fb to
f3b47d3
Compare
f3b47d3 to
7bd04a2
Compare
7bd04a2 to
fdb75d9
Compare
victor-dumitrescu
approved these changes
Feb 5, 2026
NSant215
approved these changes
Feb 5, 2026
NSant215
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RV-897
What
Use the
Bytesstate component inDataSpace'sProveandVerifymodal representation.Why
In
ProveandVerifymode,DataSpace's main complexity comes from handling the underlying byte array. This complexity can be replaced with theBytescomponent, thereby deduplicating it.How
Bytes::newnow takes a length to make non-empty instantiation easier. This is used by theDataSpacecomponent. The zero-length creation is available viaDefault.Sourceallows distinction between borrowed and owned representation viaBorrow. We make use of this when instantiating theBytescomponent inDataSpace'sstart_proofimplementation, as borrowingBytes'sNormal-mode representation isn't an option from aDataSpace<Normal>.DataSpace::populate_pages_with_bytesuses the newBytes::zero_init_rangeto achieve whole-page writes.Manually Testing
Tasks for the Author