Skip to content

test(bytes): add comprehensive test suite#735

Merged
vapourismo merged 1 commit intomainfrom
ole/push-vnsyxyzpssuk
Feb 2, 2026
Merged

test(bytes): add comprehensive test suite#735
vapourismo merged 1 commit intomainfrom
ole/push-vnsyxyzpssuk

Conversation

@vapourismo
Copy link
Copy Markdown
Collaborator

@vapourismo vapourismo commented Jan 20, 2026

What

Add a test suite for the Bytes state component.

Why

Make things nicely tested.

Manually Testing

make all

Tasks for the Author

  • Link all Linear issues related to this MR using magic words (e.g. part of, relates to, closes).
  • Eliminate dead code and other spurious artefacts introduced in your changes.
  • Document new public functions, methods and types.
  • Make sure the documentation for updated functions, methods, and types is correct.
  • Add tests for bugs that have been fixed.
  • Explain changes to regression test captures when applicable.
  • Write commit messages in agreement with our guidelines.
  • Self-review your changes to ensure they are high-quality.
  • Complete all of the above before assigning this MR to reviewers.

Copy link
Copy Markdown
Collaborator Author

vapourismo commented Jan 20, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (40f2494) to head (f2bc2e1).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   89.49%   90.33%   +0.84%     
==========================================
  Files         109      109              
  Lines       20769    20769              
  Branches    20769    20769              
==========================================
+ Hits        18587    18762     +175     
+ Misses       1803     1628     -175     
  Partials      379      379              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from ebfde52 to eadd6c9 Compare January 20, 2026 17:50
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from d2a2a70 to 63a7421 Compare January 20, 2026 17:50
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from eadd6c9 to 1903262 Compare January 20, 2026 18:35
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 46065c4 to 8d4b8fe Compare January 21, 2026 12:44
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch 2 times, most recently from 55e6424 to c71ccb7 Compare January 21, 2026 13:17
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from dfc519d to a2df18d Compare January 21, 2026 13:41
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch 2 times, most recently from cf3fff8 to a815f2f Compare January 21, 2026 14:23
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from a2df18d to 36339a0 Compare January 21, 2026 14:23
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from a815f2f to cde2f76 Compare January 21, 2026 14:27
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 24d209e to ce61947 Compare January 21, 2026 14:28
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from cde2f76 to cc81a07 Compare January 21, 2026 14:28
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from ce61947 to c9dd53d Compare January 21, 2026 14:47
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch 2 times, most recently from c269ea2 to cc52cd8 Compare January 21, 2026 15:02
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from c9dd53d to 606c201 Compare January 21, 2026 15:02
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from cc52cd8 to d45f6d4 Compare January 21, 2026 16:31
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 0ba603f to 500aac2 Compare January 21, 2026 16:32
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch 2 times, most recently from 6e09a70 to c045a41 Compare January 21, 2026 16:49
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from 500aac2 to 54505d3 Compare January 21, 2026 16:49
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from c045a41 to 546198c Compare January 21, 2026 16:53
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 7483946 to f4fd5a9 Compare January 22, 2026 14:05
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch 2 times, most recently from 80b61bf to 65b74c7 Compare January 22, 2026 14:07
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from f4fd5a9 to 660ad21 Compare January 22, 2026 14:07
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from 65b74c7 to c39f263 Compare January 22, 2026 14:11
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from 660ad21 to 432a5b7 Compare January 22, 2026 14:11
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from c39f263 to 06b94ac Compare January 22, 2026 15:17
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 11c2806 to 41b0345 Compare January 22, 2026 15:44
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch 2 times, most recently from 5f5a77a to 6f72f05 Compare January 22, 2026 15:53
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from 41b0345 to 0bfe0b9 Compare January 22, 2026 15:53
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from 0bfe0b9 to e71f173 Compare January 22, 2026 16:10
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from 6f72f05 to dc96197 Compare January 22, 2026 16:10
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from e71f173 to f5e762e Compare January 22, 2026 17:19
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from 6375e82 to b8c4b06 Compare January 23, 2026 12:46
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 283cb4b to bc2be57 Compare January 23, 2026 12:51
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from 5c7dfae to c38de98 Compare January 23, 2026 12:53
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch 2 times, most recently from 5da524b to a84b8a1 Compare January 23, 2026 16:09
@vapourismo vapourismo force-pushed the ole/push-wwwwloqpkkrz branch from c38de98 to 48f7fe4 Compare January 23, 2026 16:09
@vapourismo vapourismo force-pushed the ole/push-vnsyxyzpssuk branch from a84b8a1 to dfd7542 Compare January 23, 2026 16:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

Benchmark results for revision 0bf96e0:

Metric Duration TPS
Mean 1.513955708s 26.421
Worst 1.52257623s 26.271
Best 1.506836764s 26.546
Standard Deviation ±4.868281ms ±0.085
Full results
Run Transfers Duration TPS
1 40 1.52257623s 26.271
2 40 1.515423444s 26.395
3 40 1.515957703s 26.386
4 40 1.519193724s 26.330
5 40 1.507451198s 26.535
6 40 1.514949434s 26.404
7 40 1.506836764s 26.546
8 40 1.509419706s 26.500
9 40 1.507461507s 26.535
10 40 1.518693035s 26.338
11 40 1.508975089s 26.508
12 40 1.512370072s 26.449
13 40 1.517208546s 26.364
14 40 1.508748929s 26.512
15 40 1.517516106s 26.359
16 40 1.514486968s 26.412
17 40 1.509959174s 26.491
18 40 1.51165881s 26.461
19 40 1.522548858s 26.272
20 40 1.517678863s 26.356

Compare the results above with those for the default branch.

Copy link
Copy Markdown
Contributor

@thomasathorne thomasathorne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a few small comments.

Comment thread data/src/components/bytes/tests.rs Outdated
Comment thread data/src/components/bytes/tests.rs Outdated
Comment thread data/src/components/bytes/tests.rs Outdated
Comment thread data/src/components/bytes/tests.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants