Return EXIT_SUCCESS/EXIT_FAILURE from main() #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macros exist for a reason; not all systems use the same integer values to signal success or failure. Although all systems that TGUI currently supports use a 0 return from main to indicate success and everything else as failure, that's not universal. For example, VMS uses 1 to indicate success. In the future TGUI may be ported to systems where the EXIT_SUCCESS/EXIT_FAILURE macros are relevant, so that's one reason to use them and also; they are just a lot more expressive/readable and make perfectly clear what's being returned, so that's another reason to use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macros exist for a reason; not all systems use the same integer values to signal success or failure. Although all systems that TGUI currently supports use a 0 return from main to indicate success and everything else as failure, that's not universal. For example, VMS uses 1 to indicate success.
In the future TGUI may be ported to systems where the EXIT_SUCCESS/EXIT_FAILURE macros are relevant, so that's one reason to use them and also; they are just a lot more expressive/readable and make perfectly clear what's being returned, so that's another reason to use them.