Conversation
3w36zj6
force-pushed
the
feature/migrate-to-mise-toml
branch
from
eeb74fb to
1420acf
Compare
There was a problem hiding this comment.
Pull request overview
Migrates the repository’s toolchain pinning from an .tool-versions file to a mise.toml configuration, aligning local development and (some) CI setup with mise.
Changes:
- Add
mise.tomlwith pinned versions for bun/node and GitHub Actions linters. - Remove the existing
.tool-versionsfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mise.toml |
Introduces mise-managed tool version pins for the repo toolchain. |
.tool-versions |
Removes the previous asdf-style tool version pins. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1 | ||
| - name: Get Node.js version from mise.toml | ||
| id: node-version | ||
| run: echo "version=$(mise ls --local --json | jq -r '.node[0].requested_version')" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
The mise ls JSON is being queried with .node[0].requested_version, but mise.toml defines the tool as nodejs. This likely makes the jq expression fail at runtime (missing key) and will break publishing. Update the jq filter (or the tool name in mise.toml) so the JSON key matches, and consider using a more direct command like mise current <tool> to avoid relying on ls output structure.
| run: echo "version=$(mise ls --local --json | jq -r '.node[0].requested_version')" >> "$GITHUB_OUTPUT" | |
| run: echo "version=$(mise ls --local --json | jq -r '.nodejs[0].requested_version')" >> "$GITHUB_OUTPUT" |
| - uses: jdx/mise-action@146a28175021df8ca24f8ee1828cc2a60f980bd5 # v3.5.1 | ||
| - name: Get Node.js version from mise.toml | ||
| id: node-version | ||
| run: echo "version=$(mise ls --local --json | jq -r '.node[0].requested_version')" >> "$GITHUB_OUTPUT" | ||
| - uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0 |
There was a problem hiding this comment.
This workflow likely installs Node.js twice: once via jdx/mise-action (because mise.toml includes nodejs) and again via actions/setup-node. That adds unnecessary time and potential version drift. Consider configuring mise-action to only install the non-Node tools needed here (e.g., bun/jq) or rely on mise for Node and avoid reinstalling it with setup-node (while still configuring npm auth/registry).
| zizmor="1.18.0" | ||
| actionlint="1.7.9" | ||
| ghalint="1.5.3" | ||
| jq = "1.8.1" |
There was a problem hiding this comment.
In mise.toml, jq is the only entry using spaced = (jq = "1.8.1") while the rest use tool="version". Consider normalizing the formatting for consistency to reduce churn in future edits.
| jq = "1.8.1" | |
| jq="1.8.1" |
No description provided.