Skip to content

fix(runtime): expose instance creation time in runtime bindings #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onutc merged 1 commit into from
Mar 30, 2026
+21 −8
Merged

fix(runtime): expose instance creation time in runtime bindings #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions api/runtime_bindings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"net/http"
"strings"
"time"

"github.com/labstack/echo/v4"
apierrors "k8s.io/apimachinery/pkg/api/errors"
Expand All @@ -25,6 +26,7 @@ type runtimeBindingRuntimePrincipal struct {
type runtimeBindingResponse struct {
InstanceID string `json:"instanceId"`
Namespace string `json:"namespace"`
CreatedAt string `json:"createdAt"`
OwnerPrincipal runtimeBindingOwnerPrincipal `json:"ownerPrincipal"`
RuntimePrincipal runtimeBindingRuntimePrincipal `json:"runtimePrincipal"`
PresetID string `json:"presetId"`
Expand Down Expand Up @@ -72,6 +74,10 @@ func buildRuntimeBindingResponse(spritz *spritzv1.Spritz) (runtimeBindingRespons
if namespace == "" {
return runtimeBindingResponse{}, fmt.Errorf("instance namespace is required")
}
if spritz.CreationTimestamp.IsZero() {
return runtimeBindingResponse{}, fmt.Errorf("instance creation timestamp is required")
}
createdAt := spritz.CreationTimestamp.Time.UTC().Format(time.RFC3339Nano)

ownerID := strings.TrimSpace(spritz.Spec.Owner.ID)
if ownerID == "" {
Expand All @@ -96,6 +102,7 @@ func buildRuntimeBindingResponse(spritz *spritzv1.Spritz) (runtimeBindingRespons
return runtimeBindingResponse{
InstanceID: instanceID,
Namespace: namespace,
CreatedAt: createdAt,
OwnerPrincipal: runtimeBindingOwnerPrincipal{
ID: ownerID,
Type: "user",
Expand Down
22 changes: 14 additions & 8 deletions api/runtime_bindings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"net/http/httptest"
"strings"
"testing"
"time"

"github.com/labstack/echo/v4"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -37,8 +38,9 @@ func newRuntimeBindingsTestServer(t *testing.T, objects ...*spritzv1.Spritz) *se
func TestGetRuntimeBindingReturnsCanonicalFacts(t *testing.T) {
spritz := &spritzv1.Spritz{
ObjectMeta: metav1.ObjectMeta{
Name: "zeno-delta-breeze",
Namespace: "spritz-production",
Name: "zeno-delta-breeze",
Namespace: "spritz-production",
CreationTimestamp: metav1.NewTime(time.Date(2026, time.March, 30, 12, 34, 56, 0, time.UTC)),
Annotations: map[string]string{
presetIDAnnotationKey: "zeno",
instanceClassAnnotationKey: "personal-agent",
Expand Down Expand Up @@ -73,6 +75,7 @@ func TestGetRuntimeBindingReturnsCanonicalFacts(t *testing.T) {
`"serviceAccountName":"zeno-agent-abcd1234"`,
`"presetId":"zeno"`,
`"instanceClassId":"personal-agent"`,
`"createdAt":"2026-03-30T12:34:56Z"`,
}
for _, fragment := range expectedFragments {
if !strings.Contains(rec.Body.String(), fragment) {
Expand All @@ -84,8 +87,9 @@ func TestGetRuntimeBindingReturnsCanonicalFacts(t *testing.T) {
func TestGetRuntimeBindingRejectsMissingServiceAccountName(t *testing.T) {
spritz := &spritzv1.Spritz{
ObjectMeta: metav1.ObjectMeta{
Name: "openclaw-morning-sky",
Namespace: "spritz-production",
Name: "openclaw-morning-sky",
Namespace: "spritz-production",
CreationTimestamp: metav1.NewTime(time.Date(2026, time.March, 30, 12, 34, 56, 0, time.UTC)),
Annotations: map[string]string{
presetIDAnnotationKey: "openclaw",
instanceClassAnnotationKey: "assistant-runtime",
Expand All @@ -112,8 +116,9 @@ func TestGetRuntimeBindingRejectsMissingServiceAccountName(t *testing.T) {
func TestGetRuntimeBindingRejectsIncompleteBinding(t *testing.T) {
spritz := &spritzv1.Spritz{
ObjectMeta: metav1.ObjectMeta{
Name: "zeno-delta-breeze",
Namespace: "spritz-production",
Name: "zeno-delta-breeze",
Namespace: "spritz-production",
CreationTimestamp: metav1.NewTime(time.Date(2026, time.March, 30, 12, 34, 56, 0, time.UTC)),
Annotations: map[string]string{
presetIDAnnotationKey: "zeno",
},
Expand Down Expand Up @@ -141,8 +146,9 @@ func TestGetRuntimeBindingRejectsIncompleteBinding(t *testing.T) {
func TestGetRuntimeBindingRejectsNamespaceOutsideServerScope(t *testing.T) {
spritz := &spritzv1.Spritz{
ObjectMeta: metav1.ObjectMeta{
Name: "zeno-delta-breeze",
Namespace: "spritz-production",
Name: "zeno-delta-breeze",
Namespace: "spritz-production",
CreationTimestamp: metav1.NewTime(time.Date(2026, time.March, 30, 12, 34, 56, 0, time.UTC)),
Annotations: map[string]string{
presetIDAnnotationKey: "zeno",
instanceClassAnnotationKey: "personal-agent",
Expand Down
Loading