fix: map testnet blockchain name for indexer API calls#13
Open
ben-kaufman wants to merge 1 commit intotetherto:mainfrom
Open
fix: map testnet blockchain name for indexer API calls#13ben-kaufman wants to merge 1 commit intotetherto:mainfrom
ben-kaufman wants to merge 1 commit intotetherto:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
resolveWalletBalances()andresolveWalletTransactions()useNetworkTypeenum values directly as theblockchainfield in indexer API requests. On mainnet this works,'ethereum'is accepted. On Sepolia, the indexer expects'sepolia', not'ethereum'.The API returns empty results with no error, so balances and transactions silently show as zero/empty.
No testnet blockchain name mapping exists anywhere in the codebase.
Fix
Add
getIndexerBlockchainName()andfromIndexerBlockchainName()methods that map'ethereum'<>'sepolia'when the chain config indicates Sepolia (chain ID11155111).Applied to both
resolveWalletBalances()andresolveWalletTransactions()request payloads. The reverse mapping inresolveWalletBalances()ensures response data is keyed with the internalNetworkTypevalue ('ethereum') so downstream consumers are unaffected.