Draft: [Azure storage] as a part of fileUploader mode#146
Closed
mykhailiukVitalii wants to merge 14 commits intomasterfrom
Closed
Draft: [Azure storage] as a part of fileUploader mode#146mykhailiukVitalii wants to merge 14 commits intomasterfrom
mykhailiukVitalii wants to merge 14 commits intomasterfrom
Conversation
DavertMik
requested changes
May 29, 2023
| * @param {string} filepath - The filepath to be uploaded. | ||
| * @param {string} runId - The ID of the run or identifier for the file. | ||
| */ | ||
| const handleFileUploadByPath = async (runId, filepath) => { |
Contributor
There was a problem hiding this comment.
Please transform into class
Contributor
Author
There was a problem hiding this comment.
in my opinion, this is not a good idea. It is better to use the uploadManager to handle different download options such as S3 or Azure
mykhailiukVitalii
force-pushed
the
100-azure-store
branch
from
9c44539 to
b25dc31
Compare
Contributor
Author
|
It remains to delete the old fileUploadfile and carefully recheck the reporter based on the popular frameworks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP:
/examplesfolder (all adapter tests)