You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for raising this PR @mikeshtro
I also got a question. Do you think it's useful to also add this config to the render method, because currently it's set at the global level using the configure method.
My reasoning is that either you use zoneless or not for the whole application, and thus it isn't needed to set at test-level.
My original idea was to add it to the render method, because I consider it to be the main method, how I setup my tests when using testing library.
But as you described we use zoneless or not for the whole application and so I think the configure method is enough, because it covers the main scenario. If we want to configure it at test-level we can always provide it manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes zoneless flag in the configure function. I tried to use the configure function with zoneless flag
but I got error
Unexpected value 'undefined' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.This is because
provideZonelessChangeDetectionis incorrectly used insideimportsinstead ofproviders.