More typing improvements#119
Merged
Merged
Conversation
jelmer
requested changes
Feb 20, 2026
Otherwise the return value is typed as the Fixture class instead of the actual class. Signed-off-by: Stephen Finucane <stephen@that.guru>
This ensures args and kwargs are actually valid the cleanup function(s) in question. Signed-off-by: Stephen Finucane <stephen@that.guru>
Actually expose the kwargs expected. Signed-off-by: Stephen Finucane <stephen@that.guru>
jelmer
approved these changes
Feb 23, 2026
stephenfin
added a commit
to stephenfin/testtools
that referenced
this pull request
Mar 24, 2026
Like b1e4145 but for our tests. We also remove a FIXME that is no longer valid: the bug in fixtures was fixed in [1] [1] testing-cabal/fixtures#119 Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
added a commit
to stephenfin/testtools
that referenced
this pull request
Mar 24, 2026
Like b1e4145 but for our tests. We also remove a FIXME that is no longer valid: the bug in fixtures was fixed in [1] [1] testing-cabal/fixtures#119 Signed-off-by: Stephen Finucane <stephen@that.guru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details/motivation.
This change is