feat(mssqlserver): support GO as default batch separator#11587
Open
dahyvuun wants to merge 1 commit intotestcontainers:mainfrom
Open
feat(mssqlserver): support GO as default batch separator#11587dahyvuun wants to merge 1 commit intotestcontainers:mainfrom
dahyvuun wants to merge 1 commit intotestcontainers:mainfrom
Conversation
Signed-off-by: dahyvuun <dahyvuun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSSQL tooling (e.g. sqlcmd) uses
GOas the default batch separator instead of;.This caused issues when passing MSSQL scripts directly to Testcontainers, requiring manual preprocessing.
This change:
getStatementSeparator()method toJdbcDatabaseContainer(defaults to;)MSSQLServerContainerto returnGOrunInitScriptoverload inScriptUtilsthat accepts a custom separatorCloses #11231