Support SHA256 digest lookup in local image cache#11585
Open
konstantinosGkilas wants to merge 1 commit intotestcontainers:mainfrom
Open
Support SHA256 digest lookup in local image cache#11585konstantinosGkilas wants to merge 1 commit intotestcontainers:mainfrom
konstantinosGkilas wants to merge 1 commit intotestcontainers:mainfrom
Conversation
Index images by their repoDigests in addition to repoTags when populating LocalImagesCache so that digest-based image references (e.g. alpine@sha256:...) resolve from cache without requiring an extra inspectImageCmd call. Closes testcontainers#1406
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repoDigestsin addition torepoTagswhen populatingLocalImagesCachealpine@sha256:...) now resolve from cache without requiring an extrainspectImageCmdcallProblem
LocalImagesCache.populateFromList()only indexed images byrepoTags. When users referenced images by SHA256 digest, the cache lookup missed, forcing a redundantinspectImageCmdcall on every run.Changes
LocalImagesCache.java:populateFromList()now processes bothimage.getRepoTags()andimage.getRepoDigests(), adding cache entries for eachLocalImagesCacheTest.java: New test class covering tag-only, digest-only, mixed, duplicate, and null scenariosNote
Bare image IDs (
sha256:...without a repository prefix) are not indexed becauseDockerImageNamedoes not support that format. This could be addressed separately if needed.Test plan
LocalImagesCacheTest— 7 unit tests covering all cache population pathscheckstyleMain/checkstyleTest/spotlessCheckpassCloses #1406