Handle sub second pulls in LoggedPullImageResultCallback#11417
Open
cgunning wants to merge 1 commit intotestcontainers:mainfrom
Open
Handle sub second pulls in LoggedPullImageResultCallback#11417cgunning wants to merge 1 commit intotestcontainers:mainfrom
cgunning wants to merge 1 commit intotestcontainers:mainfrom
Conversation
rnorth
approved these changes
Mar 6, 2026
Member
rnorth
left a comment
rnorth
left a comment
There was a problem hiding this comment.
It seems obvious in retrospect - I'm surprised it's taken so long for somebody to encounter this problem! This solution looks good to me. Thanks for the investigation and fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigates the issues described in [Bug]: LoggedPullImageResultCallback throws java.lang.ArithmeticException: / by zero.
From the issue:
When running tests in GitHub actions, it fails due to line 121 in LoggedPullImageResultCallback throws an java.lang.ArithmeticException: / by zero. Out of 10 times running our tests, it has failed 8 times and succeeded2. I have not been able to reproduce this in a reliable way but it seems like this would happen if a pull takes less than one full second since duration will become 0.