Put missing properties JdbcDatabaseContainer.createConnection#11371
Closed
ebyhr wants to merge 1 commit intotestcontainers:mainfrom
Closed
Put missing properties JdbcDatabaseContainer.createConnection#11371ebyhr wants to merge 1 commit intotestcontainers:mainfrom
ebyhr wants to merge 1 commit intotestcontainers:mainfrom
Conversation
findinpath
reviewed
Dec 23, 2025
| Properties properties = new Properties(info); | ||
| properties.put("user", this.getUsername()); | ||
| properties.put("password", this.getPassword()); | ||
| properties.putAll(info); |
There was a problem hiding this comment.
It makes little sense to have the properties constructed with info if we already add all its properties.
findinpath
reviewed
Dec 23, 2025
| Properties properties = new Properties(info); | ||
| properties.put("user", this.getUsername()); | ||
| properties.put("password", this.getPassword()); | ||
| properties.putAll(info); |
There was a problem hiding this comment.
fix makes sense
public class TestProperties
{
public static void main(String[] args)
{
Properties properties = new Properties();
properties.setProperty("key1", "value1");
properties.setProperty("key2", "value2");
properties.forEach((k, v) -> System.out.println(k + ": " + v));
System.out.println("--- After Copy ---");
Properties newProperties = new Properties(properties);
newProperties.forEach((k, v) -> System.out.println(k + ": " + v));
System.out.println("--- Defaults ---");
System.out.println(newProperties.getProperty("key1"));
System.out.println(newProperties.getProperty("unknown"));
}
}
Author
|
Closing due to no review activity for a few months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
Propertiesconstructor at L266 creates an empty property list. We should explicitly callputAllmethod.