Fix DockerImageName parsing when tag and digest are used#11368
Open
bedla wants to merge 1 commit intotestcontainers:mainfrom
Open
Fix DockerImageName parsing when tag and digest are used#11368bedla wants to merge 1 commit intotestcontainers:mainfrom
bedla wants to merge 1 commit intotestcontainers:mainfrom
Conversation
bedla
changed the title
Comment on lines
+68
to
+94
| // Arguments.of("", "", "myname", ":", null), | ||
| // Arguments.of("", "", "myname", ":", "latest"), | ||
| // Arguments.of("", "", "repo/myname", ":", null), | ||
| // Arguments.of("", "", "repo/myname", ":", "latest"), | ||
| // Arguments.of("registry.foo.com:1234", "/", "my-name", ":", null), | ||
| // Arguments.of("registry.foo.com:1234", "/", "my-name", ":", "1.0"), | ||
| // Arguments.of("registry.foo.com", "/", "my-name", ":", "1.0"), | ||
| // Arguments.of("registry.foo.com:1234", "/", "repo_here/my-name", ":", null), | ||
| // Arguments.of("registry.foo.com:1234", "/", "repo_here/my-name", ":", "1.0"), | ||
| // Arguments.of("1.2.3.4:1234", "/", "repo_here/my-name", ":", null), | ||
| // Arguments.of("1.2.3.4:1234", "/", "repo_here/my-name", ":", "1.0"), | ||
| // Arguments.of("1.2.3.4:1234", "/", "my-name", ":", null), | ||
| // Arguments.of("1.2.3.4:1234", "/", "my-name", ":", "1.0"), | ||
| // Arguments.of("", "", "myname", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), | ||
| // Arguments.of("", "", "repo/myname", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), | ||
| // Arguments.of( | ||
| // "registry.foo.com:1234", | ||
| // "/", | ||
| // "repo-here/my-name", | ||
| // "@", | ||
| // "sha256:1234abcd1234abcd1234abcd1234abcd" | ||
| // ), | ||
| // Arguments.of("registry.foo.com:1234", "/", "my-name", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), | ||
| // Arguments.of("1.2.3.4", "/", "my-name", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), | ||
| // Arguments.of("1.2.3.4:1234", "/", "my-name", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), | ||
| // Arguments.of("1.2.3.4", "/", "my-name", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), | ||
| // Arguments.of("1.2.3.4:1234", "/", "my-name", "@", "sha256:1234abcd1234abcd1234abcd1234abcd"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, based on discussion here #4762 I have prepared this PR.
It seems that combination of tag & digest parsing is broken.
What do you think?
Thx
Ivos