Add withBuckets method in MinIOContainer#11365
Closed
sbushmelev wants to merge 2 commits intotestcontainers:mainfrom
Closed
Add withBuckets method in MinIOContainer#11365sbushmelev wants to merge 2 commits intotestcontainers:mainfrom
sbushmelev wants to merge 2 commits intotestcontainers:mainfrom
Conversation
…r that create buckets after container started
Member
|
Hi, thanks for your contribution. Next time before submitting a PR please share the idea with us and then let's decide if we can continue with it or not. Currently, I wouldn't add more functionality to MinioContainer given its current state. Also, we are trying to avoid coupling with the cli unless really needed, for example, to start the container. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Very often when testing with using MinIOContainer.class it is necessary to create buckets in the container with minio via MinioClient every time before starting tests
Changes:
Added a method which after the start of the container with minio creates buckets