Skip execInContainer(...) null or empty command parts.#11253
Open
bedla wants to merge 1 commit intotestcontainers:mainfrom
Open
Skip execInContainer(...) null or empty command parts.#11253bedla wants to merge 1 commit intotestcontainers:mainfrom
bedla wants to merge 1 commit intotestcontainers:mainfrom
Conversation
eb30bc1 to
8d93525
Compare
8d93525 to
ce32e63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have added this small tweak to help with
nullor empty values in command array when callingexecInContainer(...)method.This will help me (and others), to write more concise code like this:
minioContainer.execInContainer( "mc", debug(), "mb", "--region=eu-central-1", "$alias/mynewbucket" ).requireSuccess() .also { println(it) } private fun debug() = if (false) { "--debug" } else { null }Instead of creating another array to be able to IF values:
What do you think?
Thx
Ivos