Skip to content

feat(review): introduce the review protocol and code-review skill#338

Merged
pentaxis93 merged 3 commits into
mainfrom
issue-331/feat-review-introduce-the-review-protoco
May 31, 2026
Merged

feat(review): introduce the review protocol and code-review skill#338
pentaxis93 merged 3 commits into
mainfrom
issue-331/feat-review-introduce-the-review-protoco

Conversation

@pentaxis93
Copy link
Copy Markdown
Collaborator

Summary

  • Introduces review as a source C-2 workflow contract that consumes change-proposal and emits exactly one typed review outcome.
  • Adds the code-review skill as the cognitive review discipline without forge-specific tooling.
  • Replaces the old review-findings runtime artifact surface with change-approved / change-needs-revision schemas, fixtures, manifest registration, and conformance coverage.

Changes

  • Registers review outcome artifact types, [[outcome_types]], the review operation handle, and a required-choice review-disposition output group in manifest.toml.
  • Adds workflow-contracts/review.toml and skills/code-review/SKILL.md.
  • Updates schema docs, the Step 2 design note, and ADR-0002 supersession guidance so current authoring points at typed review outcomes while ADR history remains intact.
  • Preserves the invalid-shared-record-type-outcomes.toml guard as the negative counterpart to the new valid review contract.

GitHub Issue(s)

Closes #331

Test plan

  • python -m tooling.conformance
  • python -m unittest discover -s tests
  • git diff --check

Adds the review C-2 contract and code-review skill, registers the review protocol with required-choice typed outcomes, and replaces review-findings with change-approved/change-needs-revision schemas and fixtures.

Refs #331
@pentaxis93 pentaxis93 merged commit 94998cc into main May 31, 2026
1 check passed
@pentaxis93 pentaxis93 deleted the issue-331/feat-review-introduce-the-review-protoco branch May 31, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(review): introduce the review protocol and code-review skill

1 participant