feat(review): introduce the review protocol and code-review skill#338
Merged
pentaxis93 merged 3 commits intoMay 31, 2026
Merged
Conversation
Adds the review C-2 contract and code-review skill, registers the review protocol with required-choice typed outcomes, and replaces review-findings with change-approved/change-needs-revision schemas and fixtures. Refs #331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reviewas a source C-2 workflow contract that consumeschange-proposaland emits exactly one typed review outcome.code-reviewskill as the cognitive review discipline without forge-specific tooling.review-findingsruntime artifact surface withchange-approved/change-needs-revisionschemas, fixtures, manifest registration, and conformance coverage.Changes
[[outcome_types]], thereviewoperation handle, and a required-choicereview-dispositionoutput group inmanifest.toml.workflow-contracts/review.tomlandskills/code-review/SKILL.md.invalid-shared-record-type-outcomes.tomlguard as the negative counterpart to the new valid review contract.GitHub Issue(s)
Closes #331
Test plan
python -m tooling.conformancepython -m unittest discover -s testsgit diff --check