fix(image): include SSH client capability in reference session image#22
Merged
Merged
Conversation
Add openssh-client to the reference session image, document the SSH client contract, and verify built images can execute ssh directly and through Git SSH transport. Refs #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssh-clientto the final reference session image so Git SSH clone and push flows can invokessh.ssh -Vand Git SSH transport checks.Changes
openssh-clientin the Dockerfile final stage.GitHub Issue(s)
Closes #21
Test plan
bash -n scripts/release-check scripts/test-release-check./scripts/release-check metadata./scripts/test-release-checkpodman build --build-arg BASE_REF=v0.1.1 --tag localhost/base:ssh-client ../scripts/release-check release v0.1.1 --container-image localhost/base:ssh-clientpodman run --rm localhost/base:ssh-client sh -lc 'command -v ssh && ssh -V'ssh://git@127.0.0.1:1/tesserine/base, expecting SSH to run before localhost connection refusal.