fix(release-ceremony): restore annotated tag identity#17
Merged
Conversation
Restore annotated tag refs after checkout, verify restored tag identity against the triggering event commit, and harden release-check metadata validation so future workflow edits preserve the trust ordering. Also reject explicit empty --container-image values at parse time so artifact validation cannot be silently bypassed. Closes #16 Refs tesserine/commons#34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/release-check metadatato enforce the new checkout, restore, event identity, and trust ordering invariants.--container-imagevalues so artifact validation cannot be silently bypassed.Changes
Restore annotated tag refsandVerify restored tag matches eventsteps to.github/workflows/release.yml.GitHub Issue(s)
Closes #16
Refs tesserine/commons#34
Test plan
bash -n scripts/release-check scripts/test-release-check./scripts/release-check metadata./scripts/release-check release v0.1.0git diff --check./scripts/test-release-check