Skip to content

fix(release-check): reject empty artifact values#136

Merged
pentaxis93 merged 1 commit into
mainfrom
issue-135-reject-empty-binary-container-paths
May 14, 2026
Merged

fix(release-check): reject empty artifact values#136
pentaxis93 merged 1 commit into
mainfrom
issue-135-reject-empty-binary-container-paths

Conversation

@pentaxis93
Copy link
Copy Markdown
Collaborator

Summary

  • Rejects supplied empty --agentd-bin and --container-image values during release-check option parsing.
  • Preserves source-only release validation when artifact options are omitted.
  • Records the release-operator-visible behavior change in the changelog.

Changes

  • Adds parse-time non-empty checks for release artifact option values.
  • Adds regression coverage for both-empty values and mixed empty/non-empty artifact validation arguments.
  • Updates CHANGELOG.md under Unreleased / Fixed.

GitHub Issue(s)

Closes #135

Test plan

  • RED: cargo test -p agentd --test release_check release_rejects_empty -- --nocapture failed before the parser change because the empty-value cases unexpectedly succeeded.
  • GREEN: cargo test -p agentd --test release_check release_rejects_empty -- --nocapture
  • cargo test -p agentd --test release_check
  • ./scripts/release-check release v0.1.2-rc.3 --agentd-bin "" fails with --agentd-bin requires a non-empty path
  • ./scripts/release-check release v0.1.2-rc.3 --container-image "" fails with --container-image requires a non-empty image
  • ./scripts/release-check release v0.1.2-rc.3
  • ./scripts/release-check metadata
  • cargo fmt --check
  • git diff --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo build --workspace
  • cargo test --workspace

Documentation

  • Updated CHANGELOG.md for the user-visible release-check behavior change.
  • Reviewed RELEASING.md, README.md, ARCHITECTURE.md, and AGENTS.md; no drifted claims found for this parser hardening.

Reject supplied empty release artifact option values during parsing so they cannot collapse into the omitted-option state and bypass validation.

Refs #135
@pentaxis93 pentaxis93 merged commit 16ee1c1 into main May 14, 2026
3 checks passed
@pentaxis93 pentaxis93 deleted the issue-135-reject-empty-binary-container-paths branch May 14, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(release-check): reject empty binary and container-image paths

1 participant