fix(release-check): reject empty artifact values#136
Merged
Conversation
Reject supplied empty release artifact option values during parsing so they cannot collapse into the omitted-option state and bypass validation. Refs #135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--agentd-binand--container-imagevalues during release-check option parsing.Changes
CHANGELOG.mdunder Unreleased / Fixed.GitHub Issue(s)
Closes #135
Test plan
cargo test -p agentd --test release_check release_rejects_empty -- --nocapturefailed before the parser change because the empty-value cases unexpectedly succeeded.cargo test -p agentd --test release_check release_rejects_empty -- --nocapturecargo test -p agentd --test release_check./scripts/release-check release v0.1.2-rc.3 --agentd-bin ""fails with--agentd-bin requires a non-empty path./scripts/release-check release v0.1.2-rc.3 --container-image ""fails with--container-image requires a non-empty image./scripts/release-check release v0.1.2-rc.3./scripts/release-check metadatacargo fmt --checkgit diff --checkcargo clippy --workspace --all-targets -- -D warningscargo build --workspacecargo test --workspaceDocumentation
CHANGELOG.mdfor the user-visible release-check behavior change.RELEASING.md,README.md,ARCHITECTURE.md, andAGENTS.md; no drifted claims found for this parser hardening.