WIP: Implement new Fan-In/Out/General#401
Open
w31t1 wants to merge 4 commits intoterryyin:masterfrom
Open
Conversation
added 4 commits
October 10, 2024 14:56
Some extensions like IO (Fan-In/Fan-Out) generate more than one data column. All these columns shall appear in the CSV output.
e60bd0f to
7f31b54
Compare
Owner
|
If you like it you should have put some tests on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace the old Fan-In/Out/General-Out metric by a new approach used in my projects.
The current code is partially not working (see #250, #358) still Work in Progress as I discovered in #102. I already state that the current calculation depends on the ordering of the input files.
The new calculation is as described in
lizard_ext/lizardio.py:The following tasks are not fulfilled:
This PR is a RFC (Request for Comments). The development is still ongoing, tests will be added for C and Python.
@terryyin : Are you interested in this change?
@mehrdad89 : Do you still want to implement your approach?
It is also a question, if it is better to create a new extension file than canibalize this one.