Skip to content

Update lizardmodified.py#349

Open
wjonessmd wants to merge 1 commit intoterryyin:masterfrom
wjonessmd:master
Open

Update lizardmodified.py#349
wjonessmd wants to merge 1 commit intoterryyin:masterfrom
wjonessmd:master

Conversation

@wjonessmd
Copy link
Copy Markdown

Lizard only does modified complexity for languages with switch/case structures (like Java). This change means modified complexity can also be done with languages that have case/when structures (like Ruby).

Lizard only does modified complexity for languages with switch/case structures (like Java). This change means modified complexity can also be done with languages that have case/when structures (like Ruby).
@terryyin
Copy link
Copy Markdown
Owner

terryyin commented Apr 4, 2022

Hi @wjonessmd , thanks for the pull request. I'm sorry that I cannot accept it as is. If it's ok and you are interested I have the following comments:

  1. Given the way you write the code, at least 10 new test cases are required (by CCN). I believe 2 or 3 new test cases should be enough, but you have to write code without so much duplicates.
  2. We do need new test cases for new logic
  3. Try not to use changing variables
  4. If you have to use changing variables, try to limit it's scope
  5. Try not to compare boolean with True or False

I'm looking forward to your updates:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants