Add product intro video to README#322
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a product introduction video to the project's README files in both English and Chinese. The reviewer recommended enhancing the video implementation for better accessibility and browser compatibility by using the
| **An open-source control plane for governed agent systems.** | ||
|
|
||
| <p align="center"> | ||
| <video src="docs/assets/openhive-product-intro.mp4" controls playsinline width="100%" title="OpenHive product introduction"></video> |
There was a problem hiding this comment.
To improve accessibility and browser compatibility, consider using a <source> tag and adding an aria-label. Additionally, adding a poster attribute with a thumbnail image would improve the visual experience while the video is loading.
Suggested change
| <video src="docs/assets/openhive-product-intro.mp4" controls playsinline width="100%" title="OpenHive product introduction"></video> | |
| <video controls playsinline width="100%" title="OpenHive product introduction" aria-label="OpenHive product introduction"> | |
| <source src="docs/assets/openhive-product-intro.mp4" type="video/mp4"> | |
| Your browser does not support the video tag. | |
| </video> |
| **Keeper** Agent 管理,**Scout** 助手运行在群聊中,**Pipeline** 任务则在后台执 | ||
| 行定时工作流。 | ||
| <p align="center"> | ||
| <video src="docs/assets/openhive-product-intro.mp4" controls playsinline width="100%" title="OpenHive 产品介绍"></video> |
There was a problem hiding this comment.
为了提高可访问性和浏览器兼容性,建议使用 <source> 标签并添加 aria-label。此外,添加 poster 属性(缩略图)可以改善视频加载前的视觉体验。
Suggested change
| <video src="docs/assets/openhive-product-intro.mp4" controls playsinline width="100%" title="OpenHive 产品介绍"></video> | |
| <video controls playsinline width="100%" title="OpenHive 产品介绍" aria-label="OpenHive 产品介绍"> | |
| <source src="docs/assets/openhive-product-intro.mp4" type="video/mp4"> | |
| 您的浏览器不支持 video 标签。 | |
| </video> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing