refactor: remove unused mockall, fix flaky tests#634
Merged
AlexMikhalev merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
4 tasks
- Remove mockall = "0.14.0" from desktop/src-tauri dev-dependencies (never used, project policy forbids mocks in tests) - Fix test_save_one_memory in terraphim_config: handle global storage singleton already initialized by other tests with different profiles - Fix test_circuit_breaker_half_open_after_cooldown in terraphim_spawner: increase sleep margin from 5ms to 50ms to prevent flaking under load Most dependency duplicates (ahash 0.7/0.8, toml 0.5/0.9, lru 0.7/0.16, thiserror 1.0/2.0) are transitive and unavoidable without upstream crate changes. Refs: #627 Co-Authored-By: Terraphim AI <noreply@anthropic.com>
AlexMikhalev
force-pushed
the
cleanup/phase-5-deps
branch
from
5405c85 to
51c5149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mockall = "0.14.0"fromdesktop/src-tauridev-dependencies (never used)test_save_one_memory: handle global storage singleton race conditiontest_circuit_breaker_half_open_after_cooldown: increase timing marginMost dependency duplicates (ahash 0.7/0.8, toml 0.5/0.9, thiserror 1.0/2.0) are transitive via upstream crates and cannot be resolved without breaking changes.
Test plan
cargo test --workspace --libpasses (all tests green)cargo check --workspacepassesCloses #627
Generated with Terraphim AI