changed durable's API to use rust durations #41
Conversation
virajmehta
changed the title
|
@codex review |
1 similar comment
|
@codex review |
|
@codex review |
1 similar comment
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .bind(queue_name) | ||
| .bind(worker_id) | ||
| .bind(claim_timeout as i32) | ||
| .bind(claim_timeout.as_secs() as i32) |
There was a problem hiding this comment.
Because WorkerOptions::claim_timeout is now a Duration, callers can pass sub‑second values (e.g., Duration::from_millis(1500)). Here that value is truncated with as_secs() before the DB claim/update, while the worker timers (and lease extender) still use the full Duration. That mismatch means the DB lease can expire earlier than the worker expects, allowing another worker to reclaim the task while the original is still running. Consider rejecting non‑integral seconds at start_worker or rounding up/normalizing to whole seconds everywhere you use claim_timeout.
Useful? React with 👍 / 👎.
No description provided.