Skip to content

fix: lock ordering & cleanup (also contains atomic checkpoints) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
virajmehta merged 9 commits into from
Dec 24, 2025
Merged

fix: lock ordering & cleanup (also contains atomic checkpoints) #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6263d73
fix: prevent lost wakeups in event await/emit race condition
virajmehta Dec 20, 2025
6f851f4
Lock Ordering + Cleanup Consolidation
virajmehta Dec 21, 2025
e6eb86c
pass task ID to more endpoints so they can lock in order efficiently
virajmehta Dec 21, 2025
3b1b099
make checkpoint writing atomically check the version
virajmehta Dec 21, 2025
7b9958b
Merge pull request #39 from tensorzero/viraj/atomic-checkpoint
GabrielBianconi Dec 21, 2025
4edacc2
added test that covers lock order case for events / claim task
virajmehta Dec 24, 2025
2a2d4c1
fmtted
virajmehta Dec 24, 2025
a314b6f
Merge branch 'main' of github.com:tensorzero/durable into viraj/lock-…
virajmehta Dec 24, 2025
72beb59
fixed fmt
virajmehta Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,15 @@ where
let checkpoint_name = self.get_checkpoint_name(name, &())?;
let duration_ms = duration.as_millis() as i64;

let (needs_suspend,): (bool,) = sqlx::query_as("SELECT durable.sleep_for($1, $2, $3, $4)")
.bind(&self.queue_name)
.bind(self.run_id)
.bind(&checkpoint_name)
.bind(duration_ms)
.fetch_one(&self.pool)
.await?;
let (needs_suspend,): (bool,) =
sqlx::query_as("SELECT durable.sleep_for($1, $2, $3, $4, $5)")
.bind(&self.queue_name)
.bind(self.task_id)
.bind(self.run_id)
.bind(&checkpoint_name)
.bind(duration_ms)
.fetch_one(&self.pool)
.await?;

if needs_suspend {
return Err(TaskError::Control(ControlFlow::Suspend));
Expand Down
Loading