refactor(compression): hoist numpy dtype map into tensor_type#3578
Open
rkuester wants to merge 1 commit into
Open
refactor(compression): hoist numpy dtype map into tensor_type#3578rkuester wants to merge 1 commit into
rkuester wants to merge 1 commit into
Conversation
rkuester
added
ci:full
veblush
reviewed
May 27, 2026
veblush
approved these changes
May 27, 2026
Add a tensor_type module that holds the single mapping from a TFLite TensorType to a numpy dtype, and convert view.py to use it. The mapping was inlined in view.py; centralizing it gives the compression tooling one place to maintain as more callers need to read tensor buffers as numpy arrays. tensor_type.to_numpy() raises ValueError for types with no clean numpy equivalent (STRING, RESOURCE, VARIANT, BFLOAT16, and the sub-byte integer types) instead of silently returning a wrong dtype. Only types with an unambiguous little-endian numpy representation are mapped. BUG=part of tensorflow#3256
Contributor
Author
|
Force-pushing a rebase onto latest main to clear a stuck merge. No code |
rkuester
force-pushed
the
feat-tensor-type
branch
from
6c64e2f to
5a24d70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a tensor_type module that holds the single mapping from a TFLite
TensorType to a numpy dtype, and convert view.py to use it. The mapping
was inlined in view.py; centralizing it gives the compression tooling
one place to maintain as more callers need to read tensor buffers as
numpy arrays.
tensor_type.to_numpy() raises ValueError for types with no clean numpy
equivalent (STRING, RESOURCE, VARIANT, BFLOAT16, and the sub-byte
integer types) instead of silently returning a wrong dtype. Only types
with an unambiguous little-endian numpy representation are mapped.
BUG=part of #3256