Updated CREF to handle bias=null for FC,Conv 8x16 CREF code#3403
Closed
unmeshna017 wants to merge 2 commits intotensorflow:mainfrom
Closed
Updated CREF to handle bias=null for FC,Conv 8x16 CREF code#3403unmeshna017 wants to merge 2 commits intotensorflow:mainfrom
unmeshna017 wants to merge 2 commits intotensorflow:mainfrom
Conversation
Contributor
unmeshna017
commented
Feb 5, 2026
unmeshna017
commented
- Streamlined the usage of GetTensorData() and GetOptionaltensorData()
- Added bias != nullptr condiition check wherever necessary.
- Streamlined the usage of GetTensorData() and GetOptionaltensorData() - Added bias != nullptr condiition check wherever necessary.
Member
|
@unmeshna017 @veblush I'm thinking these changes should be rejected. It is a valid TfLite model in which these operators can have a missing bias tensor. |
Contributor
Author
|
Adding @vp-cad and @joshih-cad as watchers. |
Contributor
|
@ddavis-2015 If I understand correctly, this PR preserves the bias handling logic even when |
Contributor
|
Reopening this PR! |
Contributor
|
@unmeshna017 I am unable to reopen this PR, since the branch was force-pushed/recreated. Can you please create a new PR for same changes? |
Contributor
Author
|
Hi, created a new Pull request for the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.