Fix TensorBoard build and runtime compatibility with TensorFlow v2.21.0-rc1#7070
Closed
psamanoelton wants to merge 2 commits intotensorflow:masterfrom
Closed
Fix TensorBoard build and runtime compatibility with TensorFlow v2.21.0-rc1#7070psamanoelton wants to merge 2 commits intotensorflow:masterfrom
psamanoelton wants to merge 2 commits intotensorflow:masterfrom
Conversation
|
@arcra can you please take a look? Thanks! |
arcra
requested changes
Mar 6, 2026
| # can get rid of the packaging dependency. | ||
| packaging | ||
| pillow | ||
| # NOTE: this version must be >= the protoc version in our WORKSPACE file. |
Member
There was a problem hiding this comment.
In my previous iteration, I was trying to bring this protoc version from our WORKSPACE file to 6.x, which was the challenging part.
I suppose that mostly matters for the no-TF mode... the "compat" protos that we copy from TF for TB to be used without TF would then likely require a runtime protobuf than what would be used with TF.
Let's see if CI passes as is, and if it does, I suppose it should be ok. Honestly, this whole protobuf version compatibility issue is a bit confusing for me.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Update TensorBoard dependency configuration to work with TensorFlow 2.21.0rc1
Technical description of changes
six>=1.16.0to runtime requirements (required by TensorFlow).These updates resolve dependency conflicts observed when installing TensorBoard alongside TensorFlow 2.21.0rc1 in a clean Python environment and allow successful build, installation, and execution of TensorBoard.
Screenshots of UI changes (or N/A)
N/A
Detailed steps to verify changes work correctly (as executed by you)
Validation steps
TensorFlow import:
python -c "import tensorflow as tf; print(tf.__version__)"Build TensorBoard:
bazel build //tensorboard/pip_package:build_pip_packageRun tests:
bazel test //tensorboard/... --test_output=errorsBuild and install wheel:
./bazel-bin/tensorboard/pip_package/build_pip_package /tmp/tb_wheelpip install /tmp/tb_wheel/tensorboard-*.whlLaunch TensorBoard:
tensorboard --logdir /tmp/tb_logsAlternate designs / implementations considered (or N/A)
N/A
Notes:
Some existing test failures appear unrelated to these dependency updates and were already present prior to this change.
This PR focuses only on resolving dependency conflicts and ensuring that TensorBoard builds and runs correctly with TensorFlow 2.21.
To properly run the tests were required the usage of openjdk-17-jdk