Skip to content

refactor: drop ComponentFactoryResolver #7068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JeanMeche wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −34
Open

refactor: drop ComponentFactoryResolver #7068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions tensorboard/webapp/app_routing/views/router_outlet_component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ limitations under the License.
import {
ChangeDetectionStrategy,
Component,
ComponentFactoryResolver,
Input,
OnChanges,
SimpleChanges,
Expand All @@ -35,20 +34,12 @@ export class RouterOutletComponent implements OnChanges {

@Input() activeNgComponent!: unknown | null;

constructor(
private readonly componentFactoryResolver: ComponentFactoryResolver
) {}

ngOnChanges(changes: SimpleChanges) {
const activeComponentChange = changes['activeNgComponent'];
if (activeComponentChange) {
this.routeContainer.clear();
if (activeComponentChange.currentValue) {
const componentFactory =
this.componentFactoryResolver.resolveComponentFactory(
activeComponentChange.currentValue
);
this.routeContainer.createComponent(componentFactory);
this.routeContainer.createComponent(activeComponentChange.currentValue);
}
}
}
Expand Down
22 changes: 5 additions & 17 deletions tensorboard/webapp/customization/customizable_component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/
import {
Component,
ComponentFactoryResolver,
Input,
OnInit,
Type,
ViewContainerRef,
} from '@angular/core';
import {Component, Input, OnInit, Type, ViewContainerRef} from '@angular/core';

/**
* A Component that defines a customization point. Ideal for use for small
Expand Down Expand Up @@ -86,18 +79,13 @@ import {
export class CustomizableComponent implements OnInit {
@Input() customizableComponent!: Type<Component> | undefined;

constructor(
private readonly viewContainerRef: ViewContainerRef,
private readonly componentFactoryResolver: ComponentFactoryResolver
) {}
constructor(private readonly viewContainerRef: ViewContainerRef) {}

ngOnInit() {
if (this.customizableComponent) {
const componentFactory =
this.componentFactoryResolver.resolveComponentFactory(
this.customizableComponent.constructor as Type<unknown>
);
this.viewContainerRef.createComponent(componentFactory);
this.viewContainerRef.createComponent(
this.customizableComponent.constructor as Type<unknown>
);
}
}
}
8 changes: 1 addition & 7 deletions tensorboard/webapp/plugins/plugins_component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ limitations under the License.
import {
ChangeDetectionStrategy,
Component,
ComponentFactoryResolver,
ElementRef,
Input,
OnChanges,
Expand Down Expand Up @@ -64,7 +63,6 @@ export enum PluginLoadState {
})
export class PluginsComponent implements OnChanges {
constructor(
private readonly componentFactoryResolver: ComponentFactoryResolver,
private readonly pluginRegistry: PluginRegistryModule,
@Optional() private readonly pluginApiHost: PluginApiHostModule
) {}
Expand Down Expand Up @@ -230,12 +228,8 @@ export class PluginsComponent implements OnChanges {
case LoadingMechanismType.NG_COMPONENT:
const ngComponentClass = this.pluginRegistry.getComponent(plugin.id);
if (ngComponentClass) {
const componentFactory =
this.componentFactoryResolver.resolveComponentFactory(
ngComponentClass
);
const pluginComponent =
this.ngPluginContainer.createComponent(componentFactory);
this.ngPluginContainer.createComponent(ngComponentClass);
pluginElement = pluginComponent.location.nativeElement;
} else {
console.error(
Expand Down