Open
Conversation
It appears that pkg_config does not emit necessary 'cargo:' output.
And some dogfood.
And some dogfood.
And some dogfood.
The code is not used anywhere else.
Fixes lints "renamed_and_removed_lints", "clippy::unnecessary_to_owned", "clippy::manual_inspect", "ambiguous_glob_reexports".
cd27439 to
f8de427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all lint's (
cargo clippy --features eager,experimental,ndarray). There is also a little bit of dogfood. Follow commit messages for more context.A cool library, thanks for the work! While getting to know the code by working with
example/xor.rsI was figuring I can contribute a little bit.I have a few more ideas, maybe I find time to work with those:
.pcfile is available,tensorflow-sys (build.rs)took long in the build process. I manually installed a.pcfile. Maybe the env variableCARGO_TARGET_DIRcan be used to persistently store build artifacts across incremental builds instead of usingOUT_DIR.tensorflow-sys (build.rs)?tensorflow/core/ops/ops.pbtxtand run op-codegen in abuild.rs- I never worked with protobuf.