Keras examples for single input and multiple inputs have been added. by justnoxx · Pull Request #286 · tensorflow/rust

justnoxx · 2020-12-18T10:41:36Z

These examples are explaining how to use saved models created using Keras.
1st example explains how to use the model when there is precisely one input operation.
2nd example shows how to deal with models where more than one input ops.

google-cla · 2020-12-18T10:41:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

justnoxx · 2020-12-18T10:47:16Z

@googlebot I signed it!

justnoxx · 2020-12-18T10:48:30Z

@adamcrume there are some examples related to Keras that I mentioned in #282
Please, let me know what I should change if required to make it merged.
Thanks.

/Dmitriy

adamcrume

Looks good, just a few minor style issues.

Also, please run cargo fmt.

adamcrume · 2020-12-31T17:32:10Z

examples/keras_multiple_inputs_saved_model.rs

+    let save_dir = "examples/keras_multiple_inputs_saved_model";
+    let v1: Vec<f32> = vec![0.1, 0.2, 0.3, 0.4, 0.5];
+    let v2 = vec![0.6, 0.7, 0.8, 0.9, 0.1];
+    let tensor1 = vector_to_tensor(&v1);


This can be simplified to:

let tensor1 = Tensor::from(&[0.1, 0.2, 0.3, 0.4, 0.5][..]);

no Vec or vector_to_tensor needed.

Function is removed.

adamcrume · 2020-12-31T17:34:12Z

examples/keras_multiple_inputs_saved_model.rs

+    // In this file test_in_input is being used while in the python script,
+    // that generates the saved model from Keras model it has a name "test_in".
+    // For multiple inputs _input is not being appended to the op name.
+    let input_1_op_name = "test_in1";


These aren't op names, they're signature input (or output) parameter names. I know this sounds like nitpicking, but this can be confusing, so it's important to make a clear distinction, so readers don't think they're the same thing.

Variable is renamed now.

adamcrume · 2020-12-31T17:53:18Z

examples/keras_multiple_inputs_saved_model.rs

+    let result = session.run(&mut args);
+    if result.is_err() {
+        panic!("Error occured during calculations: {:?}", result);
+    }


This can be simplified to:

session.run(&mut args).expect("Error occurred during calculations");

Simplification has been performed.

adamcrume · 2020-12-31T18:01:22Z

examples/keras_multiple_inputs_saved_model/keras_multiple_inputs_saved_model.py

+print(x1.shape)
+y = np.random.randn(100, 1)
+# print(v1.shape)
+# print(v2.shape)


Were these commented-out lines intended to be removed?

Obsolete lines have been removed.

adamcrume · 2020-12-31T18:03:46Z

examples/keras_signle_input_saved_model.rs

+    let dimension = v.len();
+    let tensor = Tensor::new(&[1, dimension as u64]).with_values(&v[..]).unwrap();
+    return tensor;
+}


This file name has a typo: signle should be single.

File has been renamed

adamcrume · 2020-12-31T18:05:14Z

examples/keras_signle_input_saved_model.rs

+    let save_dir = "examples/keras_signle_input_saved_model";
+    let v: Vec<f32> = vec![0.1, 0.2, 0.3, 0.4, 0.5];
+
+    let tensor = vector_to_tensor(&v);


As with the other file, this can be simplified to:

let tensor = Tensor::from(&[0.1, 0.2, 0.3, 0.4, 0.5][..]);

Well, it did not work for me because your code is creating tensor of dims:[5], but dim:[1, 5] is expected, so I used the following code:

let tensor: Tensor<f32> = Tensor::new(&[1, 5]) .with_values(&[0.1, 0.2, 0.3, 0.4, 0.5]) .expect("Can't create tensor");

adamcrume · 2020-12-31T18:06:39Z

examples/keras_signle_input_saved_model.rs

+    // In this file test_in_input is being used while in the python script,
+    // that generates the saved model from Keras model it has a name "test_in".
+    // For multiple inputs _input is not being appended to the op name.
+    let input_op_name = "test_in_input";


These aren't op names.

Variable has been renamed.

adamcrume · 2020-12-31T18:07:20Z

examples/keras_signle_input_saved_model.rs

+    let result = session.run(&mut args);
+    if result.is_err() {
+        panic!("Error occured during calculations: {:?}", result);
+    }


This can use expect.

Expect has been added.

justnoxx · 2021-02-24T18:13:44Z

@adamcrume sorry for delay, literally did not have time to address that, but now I did the changes that you requested. A file with typo in its name has been renamed. Cargo fmt has been also applied. Please, let me know if I need to do additional updates.

justnoxx added 2 commits December 18, 2020 12:36

Keras examples for single input and multiple inputs have been added.

ad2b532

Performed minor cleanup

43d7169

adamcrume requested changes Dec 31, 2020

View reviewed changes

justnoxx added 3 commits February 24, 2021 01:21

Performed cleanup. Applied requested changes

8c89064

One more cleanup

ce8b1c9

Updated tensor creation for single input model

756920c

justnoxx requested a review from adamcrume February 24, 2021 22:28

This was referenced Jul 13, 2021

Use signature to extract op names dskkato/tf2_python_rust#6

Merged

add zenn example to CI target dskkato/tf2_python_rust#7

Merged

Migration of Python examples to TF2.5 #309

Open

ramon-garcia pushed a commit to ramon-garcia/tensorflow-rust that referenced this pull request May 20, 2023

support decoding legacy lists with no inner element (tensorflow#286)

3765aef

Conversation

justnoxx commented Dec 18, 2020

Uh oh!

google-cla bot commented Dec 18, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

justnoxx commented Dec 18, 2020

Uh oh!

justnoxx commented Dec 18, 2020

Uh oh!

adamcrume left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justnoxx commented Feb 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants