Add new scripts for building and cleaning wheels #925
+610
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These encapsulate instructions from Michael Broughton about how to build new versions of TensorFlow Quantum.
The final print statement about the directory is misleading when `build_pip_package.sh` is being run inside a Docker container. On balance, I think it's better to remove it. Hopefully the user running the script will remember that they supplied the destination parameter as an argument on the command line to begin with.
mhucka
added
area/devops
Per Google guidance, executable scripts should use `/bin/bash`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new scripts in
release/encapsulate instructions from Michael Broughton about how to build new distributions of TensorFlow Quantum. The filerelease/README.mddescribes how to use them. There are unit tests as well; they can be invoked using bazel (and the process is also described in the README file).There are a couple of tweaks to
release/build_pip_package.shto take a debug tracing argument and make the script work inside the Docker containers run by the build script.(Note: this PR is meant to be merged after PR #913 is merged.)