refactor(sdk): add artifact-centered runtime realization#190
Conversation
Signed-off-by: wolegechu <ychu.luo@gmail.com>
Signed-off-by: wolegechu <ychu.luo@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed1caa5f47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| @classmethod | ||
| def publication( | ||
| def _publication( |
There was a problem hiding this comment.
Keep publication constructor public on ArtifactRealizationSpec
Renaming ArtifactRealizationSpec.publication(...) to _publication(...) removes an existing public constructor without providing a replacement, so callers upgrading to this commit will hit AttributeError when building publication realization specs through the documented classmethod path. Because the publication target kind is still implemented, this is a behavioral regression rather than an intentional removal of the feature; keep a public publication classmethod (or a compatibility alias) to preserve runtime behavior.
Useful? React with 👍 / 👎.
Summary
tensorcast.servingruntime surfaces.tensorcastfocused on artifact/runtime APIs.Why
This follows the artifact-first runtime realization design: artifact identity, lifecycle, retained handoff, and runtime diagnostics should be expressed through artifact/runtime concepts instead of a parallel serving-session surface.
Validation
ruff checkvia pre-commitruff formatvia pre-commitTENSORCAST_SKIP_TORCH_ABI_CHECK=1 pytest tests/python/api/test_public_surface.py tests/python/test_serving_publication_types.py tests/python/artifact_runtime/artifact/test_resolver.py tests/python/artifact_runtime/test_fake_framework_boundary.py tests/python/artifact_runtime/test_lifecycle.py tests/python/artifact_runtime/test_readiness.py tests/python/artifact_runtime/recipe/test_build_session.py tests/python/artifact_runtime/recipe/test_validation.py tests/python/test_pytorch_module_binding.py -q