Skip to content

refactor(sdk): add artifact-centered runtime realization#190

Merged
wolegechu merged 28 commits into
mainfrom
codex/0120-artifact-runtime-realization-review-20260526
May 27, 2026
Merged

refactor(sdk): add artifact-centered runtime realization#190
wolegechu merged 28 commits into
mainfrom
codex/0120-artifact-runtime-realization-review-20260526

Conversation

@wolegechu
Copy link
Copy Markdown
Contributor

Summary

  • Move model-runtime realization toward the artifact-runtime boundary and remove public tensorcast.serving runtime surfaces.
  • Preserve serving-publication ABI helpers under store/builder modules while keeping root tensorcast focused on artifact/runtime APIs.
  • Update tests, examples, and docs for the artifact-centered model-runtime realization path.

Why

This follows the artifact-first runtime realization design: artifact identity, lifecycle, retained handoff, and runtime diagnostics should be expressed through artifact/runtime concepts instead of a parallel serving-session surface.

Validation

  • ruff check via pre-commit
  • ruff format via pre-commit
  • TENSORCAST_SKIP_TORCH_ABI_CHECK=1 pytest tests/python/api/test_public_surface.py tests/python/test_serving_publication_types.py tests/python/artifact_runtime/artifact/test_resolver.py tests/python/artifact_runtime/test_fake_framework_boundary.py tests/python/artifact_runtime/test_lifecycle.py tests/python/artifact_runtime/test_readiness.py tests/python/artifact_runtime/recipe/test_build_session.py tests/python/artifact_runtime/recipe/test_validation.py tests/python/test_pytorch_module_binding.py -q

@wolegechu wolegechu marked this pull request as ready for review May 26, 2026 03:26
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed1caa5f47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


@classmethod
def publication(
def _publication(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep publication constructor public on ArtifactRealizationSpec

Renaming ArtifactRealizationSpec.publication(...) to _publication(...) removes an existing public constructor without providing a replacement, so callers upgrading to this commit will hit AttributeError when building publication realization specs through the documented classmethod path. Because the publication target kind is still implemented, this is a behavioral regression rather than an intentional removal of the feature; keep a public publication classmethod (or a compatibility alias) to preserve runtime behavior.

Useful? React with 👍 / 👎.

@wolegechu wolegechu changed the title [codex] Artifact-centered runtime realization cleanup refactor(sdk): add artifact-centered runtime realization May 26, 2026
@wolegechu wolegechu merged commit a00e257 into main May 27, 2026
5 checks passed
@wolegechu wolegechu deleted the codex/0120-artifact-runtime-realization-review-20260526 branch May 27, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant