add pNFT prep helper + cleanup #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leantOnSol
requested review from
richardwu and
samuelvanderwaal
as code owners
samuelvanderwaal
approved these changes
Feb 18, 2025
|
|
||
| export const MPL_TOKEN_METADATA_PROGRAM_ID = address( | ||
| 'metaqbxxUerdq28cj1RbAWkYQm3ybzjb6a8bt518x1s' | ||
| ); |
Contributor
There was a problem hiding this comment.
I'm not opposed to adding this here if necessary, but we already do have most token program IDs here. Might make sense to move these into common-helpers instead of having them in test-helpers tho?
Contributor
Author
There was a problem hiding this comment.
yeaaa - the overall toolkit structure is quite messy, I think we could move a lot from test-helpers over to common-helpers (if it's not test specific), but I think that's a bigger task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepPnftMetadata(web3js 2.0 equivalent to https://github.com/tensor-hq/tensor-common/blob/43297c077ca71c560ee8c5ee416a2b5233c05d68/src/metaplex/token_rules.ts#L20)